Skip to content

Conversation

@norareidy
Copy link
Collaborator

@norareidy norareidy commented Jan 8, 2024

Pull Request Info

I also included a small terminology fix in this PR (derive statement -> derive attribute)

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35254
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/rust/DOCSP-35254-pool-subsections/fundamentals/performance/#std-label-rust-performance-pool

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 1 suggestion

Comment on lines 84 to 85
Alternatively, you can tune the connection pool to best fit the needs of your
application and optimize performance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Is there other info we can link to to help people who want to customize?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the subsections in this section cover a lot of the customization options, but I'll add another sentence mentioning that

@norareidy norareidy merged commit a474ca0 into mongodb:master Jan 8, 2024
@norareidy norareidy deleted the DOCSP-35254-pool-subsections branch January 8, 2024 18:47
norareidy added a commit that referenced this pull request Jan 8, 2024
norareidy added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants